octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

feat: Change link focus style to an outline. #201

Closed sarahmonster closed 4 years ago

sarahmonster commented 4 years ago

This is more consistent with focus states used elsewhere (ie, for buttons) and avoids weirdness where sometimes the background is too dark, and the contrast gets shot, like this:

Before:

Screenshot 2020-03-12 at 15 54 21 Screenshot 2020-03-12 at 15 55 02

Ultimately, we'll want to rejig the Link (and Button) components to allow for super-flexible hover and focus styling, but for now, this should give us a more consistent and sensible default behaviour. See also #200, which I've just filed.

And it should help with https://github.com/octopusthink/getmicdrop.com/issues/11, which is basically why I'm bothering to fix this now. 😜