octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

Add a new ComboBox component #206

Closed sarahmonster closed 4 years ago

sarahmonster commented 4 years ago

Fixes #138.

Still on my to-do list here:

It'll also require @tofumatt's help to make it functional, and we'll want to work on a secondary PR to make the autocomplete/searching bit work as well.

Comboboxes:

Selects:

Technical/implementation notes:

sarahmonster commented 4 years ago

I'm working on the docs for this here: https://www.notion.so/octopusthink/Combobox-80fa2fd9ce4b464ab7ced7757297543f (still in progress!)

There are two key components we'll want to make a Combobox really robust:

And a few things we may want to fix in this PR, but I don't know how:

I think those can wait for a follow-on PR, in the interests of keeping things simple, because we can make use of the combobox without those functionalities. Also, I'll probably need (a lot of!) help implementing those, since there's lots of complexity there.

My tests are failing fairly enthusiastically here. I wanted to start writing tests but I'm a bit confused that it looks like some unrelated tests are failing, and I can't seem to/am not sure how to generate snapshots. @tofumatt when you have a moment I'd love your help sussing out what's going on!