search

octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

chore: Switch to relative import paths #213

Closed tofumatt closed 4 years ago

tofumatt commented 4 years ago

So, this is a massive PR, but I figured I'd get it out of the way. This will help with VSCode integration, it helps tidy up our path configs, and it means we can possibly migrate to TypeScript (#199) with less pain.

This tidies up and makes consistent a lot of our imports too. It lessens the likelihood of circular imports, which is one of the reasons our internal imports were previously inconsistent (eg. sometimes using import { Header } from 'components'; and other times using import Header from 'components/Header';).

There's no sense in reviewing this code. All the tests continue to pass despite no changes to them (aside from changing the paths they use).

What would be useful is running this locally and comparing the local styleguide to the published version you see on the web/what you expect. If that looks good we can get this merged. 😅

tofumatt commented 4 years ago

Good catch, thanks! That was only happening on some pages and was due to an incomplete refactor. Fixed and ready for re-review!