octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

ComboBox: Nix double border #227

Open sarahmonster opened 4 years ago

sarahmonster commented 4 years ago

This is sort of minor, but it winds up feeling like a bug:

Screenshot 2020-05-28 at 23 26 08

We need some way of being able to tell if the popover is above or below the field (this must be doable, but I'm not sure how?) and then we can remove either the top or bottom border, respectively.

sarahmonster commented 4 years ago

I think this is related, but sometimes the positioning isn't quite right:

Screenshot 2020-05-29 at 02 02 25

(Ignore the badly-positioned caret; I fixed that already!)