octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

Paragraph + Heading spacing is too fragile #238

Open sarahmonster opened 4 years ago

sarahmonster commented 4 years ago

This rule is trying to resolve the paragraph + heading spacing problem, and it might be too clever, and we're often needing to override it.

.Nautilus-Paragraph + .css-18rem20-Timeslip-Timeslip-Timeslip-css-css winds up trying to add extra top-margin to a heading that follows a paragraph (as in here) so that a heading is closer to the text it heads up. I often write global style rules for this as well, because it doesn't quite do a good enough job of spacing things properly on its own, so we might need to reconsider how this rule is applied (if at all) in Nautilus.

It may help to review

a) how we're actually using + applying spacing around components in sites/products that use Nautilus b) whether that spacing is effective c) how we can better accomodate spacing needs across a product and editorial context