search

octoshrimpy / bulma-o-steps

In-depth Steps component for Bulma.io
https://octoshrimpy.github.io/bulma-o-steps
GNU General Public License v3.0
84 stars 35 forks source link

Interferes with stock Bulma #15

Closed riovir closed 5 years ago

riovir commented 5 years ago

The extension alters various unrelated Bulma aspects. It most likely closely relates to Issue #9.

The offending line(s) of code can be found here. They force for instance the Button element's justify-content to revert back to flex-start by re-applying the control mixin on it.

It may be okay to include stock Bulma for a CSS-only output, but for projects that use sass / scss it actually hurts to copy the unversioned fragments of Bulma into the extension.

The minimal change to fix the issue would be simple:

Extract everything but the top import from https://github.com/octoshrimpy/bulma-o-steps/blob/master/bulma-steps.sass to a new file and allow projects importing that instead. This way the extension will be powered by their variables and mixins.

For backward compatibility the old bulma-steps.sass can simply import the new file into itself effectively being only 2-3 lines of code.

riovir commented 5 years ago

I've made an attempt to allow consumers of the extension to import bulma-o-steps/index.sass instead to be free of side effects via this pull request: https://github.com/octoshrimpy/bulma-o-steps/pull/16

octoshrimpy commented 5 years ago

looks good! I'm currently in the middle of rewriting the extension from scratch into separate file for easier customizing/managing, as it was pulled from aramvisser's extension, and the code was a large ball of spaghetti.