search

octoshrimpy / bulma-o-steps

In-depth Steps component for Bulma.io
https://octoshrimpy.github.io/bulma-o-steps
GNU General Public License v3.0
84 stars 35 forks source link

Bulma modals break because of bulma-o-steps #37

Open eriknaslund opened 3 years ago

eriknaslund commented 3 years ago

Bulma 0.9.0 and 0.9.2 suffers from a slightly broken modal when the scss for bulma-o-steps is included. The .modal element should have position: fixed, but it gets position: absolute instead, which causes the background to only fill the top part of the screen if you scroll down.

I believe this is the same issue as in:

The workaround (as posted in the linked issues) is to simply change your scss import from bulma-steps.sass to index.sass, like this:

- @import "../../lib/bulma-o-steps/bulma-step";
+ @import "../../lib/bulma-o-steps/index";

I'm guessing the problem originates from that fact that bulma-o-steps provides a big chunk of SASS (utilities/*) which seems to be copied from Bulma itself. At least that's what it looks like after a quick glance. This seems a bit brittle since there's a high potential for breakage during Bulma version upgrades.

I don't know SASS well enough to suggest a sensible workaround. However, when I just included the index.sass myself, and used just used the (already included) utilities from my Bulma install, then things worked great. Could the solution perhaps be as simple as:

  1. Get rid of utilities/* and bulma-steps.sass from bulma-o-steps.
  2. Change the docs to tell people to import bulma first, and then import bulma-o-steps afterwards.