search

octoshrimpy / quik

The most beautiful SMS messenger for Android - Revived
GNU General Public License v3.0
655 stars 31 forks source link

✏️ [ FEAT REQ ] Color Palette #92

Open ddanon opened 6 months ago

ddanon commented 6 months ago

Is your feature request related to a problem? If so, please describe the problem. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

This issue is contingent on having "Automatic contact colors" turned ON

I run a pretty aggressive night mode on my phone. As a result, sometimes there isn't enough contrast in the automatic contact colors for easy reading. The text, being white, is tinted red by night mode. The chat bubbles (which may already have a strong red component depending on the automatically generated color) are relatively unchanged. This results in a red-on-red low contrast scenario.

Describe the feature you'd like A clear and concise description of what you want to happen.

My proposal has a few elements:

  1. Change the current "Night mode" option to "Dark mode"
  2. Add a "Night mode" option (open to changing that name) under "Automatic contact colors"
    • Initially simply minimize the red component in all auto generated colors
    • Eventually could allow a user to whitelist some colors or only generate colors that are near a selected color

Additional context Add any other context or screenshots about the feature request here.

Thinking out loud / immediate feature creep

An alternative is to allow the user to pick two colors, one for contacts and one for non-contacts. This skips all of the fancy generation and color space considerations and leaves it up to the user to make things easy to read based on their environment. Maybe not as slick but similarly easy to use.

octoshrimpy commented 6 months ago

interesting. I agree with all of this. maybe advanced settings under the convo settings?

could you send me a screenie of the red-on-red bubbles? would love to see what that ends up looking like.

ddanon commented 6 months ago

Unfortunately a screenshot captures the color information before the red light filter i.e. it doesn't show the change. I'll see if I can get a good picture of the screen through my laptop's webcam.

ddanon commented 6 months ago

Looks like my laptop cam isn't up to the task. I'll try again with an old phone when I get back from traveling.

In the meantime I'll play around on a fork and see if I can get a good draft of the ideas above. If I do I'll submit a pull request

octoshrimpy commented 6 months ago

thank you for your help!