octree-nn / ocnn-pytorch

Octree-based Sparse Convolutional Neural Networks
MIT License
150 stars 16 forks source link

Does this implementation supports DualOctreeGNN #12

Closed fishfishson closed 1 year ago

fishfishson commented 1 year ago

Hi author, Thanks for your pure torch implementation! Your recent work DualOctreeGNN uses ocnn version from microsoft/O-CNN. Can I replace it with this repo?

wang-ps commented 1 year ago

Thanks for your interest in our papers. It is definitely possible to replace the microsoft/O-CNN with this ocnn-pytorch since ocnn-pytorch contains all the functionalities of microsoft/O-CNN and more.

And when I am free in the near future, I will also try to do it.

fishfishson commented 1 year ago

Looking forward to your next version! BTW if with this repo, can I use the original pre-trained model weight?

wang-ps commented 1 year ago

Yes, probably. DualOctreeGNN mainly reuses the octree data structure of microsoft/O-CNN, and the convolution is a newly-proposed graph convolution, which may not be affected by the replacement of ocnn-pytorch.

fishfishson commented 1 year ago

Thanks! One more question. There exists another great work Neural Dual Contouring which applies dual contour to reconstruct surfaces from points. However, it seems like we can add hierarchy ocnn to it for efficiency and accuracy. What do you think of this feasibility?

wang-ps commented 1 year ago

Yes, it is a good idea! And I think it is feasible to combine these two works. The original version of Dual Contouring uses Octree to speed up. And DualOctreeGNN uses a naive CPU-version marching cube to extract surfaces, which is actually the bottleneck of DualOctreeGNN.

fishfishson commented 1 year ago

Thx! Really appreciate all your kind answers.