Closed thclark closed 3 weeks ago
@cortadocodes I know all the tests are failing here, they're mostly failing on 2-4 tests, many of which are due to needing to patch the queue. But I've asked for a review mostly because I'm looking for what you think of the new ci
workflow.
Note: publish-test done in parallel to tests because, in this moment at least, I wanted to know it passed even though tests are failing
Also note: I'll probably squash a whole bunch of these commits, forgive the fairly crazy commit history. Usual trial-and-error BS of working with GHA, you know?!
Attention: Patch coverage is 66.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 68.04%. Comparing base (
ab44d54
) to head (6fa5367
). Report is 144 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
django_gcp/tasks/manager.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Contents (#71)
IMPORTANT: There is 1 breaking change.
Fixes
Operations
Dependencies
Testing
Style
Other
Upgrade instructions
💥 Avoid circular import of StreamHandler in some python environments
The django_gcp.logging module has been renamed to django_gcp.logs because some python environments (eg installed in tox) don't resolve the import order in the same way, so mistake django_gcp.logging for the inbuilt python logging module. To overcome this, users of the structured logging or error reporting handlers must update their handler classes to 'django_gcp.logs.GoogleStructuredLogsHandler' and 'django_gcp.logs.GoogleErrorReportingHandler' from the previous 'django_gcp.logging.