octue / planex-site

The octue website front end
https://planex-site.vercel.app
0 stars 0 forks source link

FIX: removed lorem ipsum text #21

Closed AndyClifton closed 3 years ago

AndyClifton commented 3 years ago

Contents

New Features

Breaking changes

Minor fixes and improvements

N/A

Quality Checklist

@thclark not sure of the relevance of these to planex-site?

Coverage Karma

@thclark not sure of the relevance of these to planex-site?

*Coverage Karma can be earned by disproportionally increasing test coverage in the rest of your contributions. It's an honesty policy - you keep count of your own.

gatsby-cloud[bot] commented 3 years ago

Gatsby Cloud Build Report

planex-site

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 1m

Performance

Lighthouse report

Metric Score
Performance :green_heart: 91
Accessibility :green_heart: 94
Best Practices :green_heart: 100
SEO :large_orange_diamond: 71

:link: View full report

thclark commented 3 years ago
  • Not an ideal fix: introduces new line in text blocks using discrete <typography> elements for what would usually be <p> tags in HTML. This should probably be dealt with if we decide to further split content from pages (.e.g using props and/or data files) or when linking to Wagtail.

If pulling this stuff from wagtail or injecting as props, we can

thclark commented 3 years ago

@thclark not sure of the relevance of these to planex-site?

Could be better worded for this repo but the templates are taken from our common .github repo, and I'd rather not do the maintenance of having separate ones for this repo.