octue / power-curve-schema

A repository for developing schema related to Wind Turbine Power Curves
Creative Commons Zero v1.0 Universal
1 stars 1 forks source link

Working Draft missing descriptions of acoustic-emission properties and potential mismatch in property names in schema #74

Open Dash16PM opened 2 weeks ago

Dash16PM commented 2 weeks ago

Bug report

Following input from Alex James I drilled down into the latest working draft and found some omissions/possible mismatches. These are described below:

In the report Clause 4.6.3.1.2, Table 16 we tabulate “Properties of each Operating mode” and list “acoustic_emissions” there. BUT in the schema under “operating_modes” in the list of “required” items “acoustic_emisions” does not appear. As I write I recall we made this optional.

In Table 16 we reference Table 19 of 4.6.3.1.5 where we have Properties of acoustic emissions – but I cannot find description of

“margin” “weighting” “frequency” or “sound_pressure_level” properties.

It looks like the schema I am looking at on Github has some disconnects with the working draft on rows 1376 potentially through 1560.

What is the expected behavior?

We need to have the labeling harmonized between the schema and the working draft, plus ensure the working draft has all the properties/sub properties used in the schema.

Dash16PM commented 1 week ago

Tom, I made the following changes in the Draft Standard. These changes should avoid any code changes. p.s. I found the way acoustic stuff is organized within the schema a bit confusing - but schemas are not my world so it may be normal and ok.

First change - added a definition of spl: 3.1.16 sound pressure level a measure of the strength of an acoustic wave in decibels (dB)

more major changes where you may or may not approve are in Table 19:

Where I added comments under the description of terms that have "mismatches" to try to explain this mismatch e.g.

acoustic_emissions_margin

A recommended margin of error [dB] which may be added to the given sound pressure levels for practical use. (Abbreviated in schema to "margin" to simplify coding.)

repeated for acoustic emission weighting, wind speed and frequency

Added definition of sound_pressure_level with comment:

The sound pressure level [db], specified as a matrix for the given ranges of wind speed and frequency. Total sound pressure level can be derived by summation along the frequency dimension using the logarithmic method.

("sound_pressure_level" is the unit used to represent acoustic emissions, whether presented in the form of one-third octave, full-octave, or total sound pressure.)

Please review and let me know if this is sufficient or you prefer to make changes in the schema to harmonize better.

Thanks

Emil