search

octylFractal / ts2kt-unofficial-gradle-plugin

MIT License
2 stars 2 forks source link

Missing Groovy DSL Compatibility #4

Open timothyolt opened 5 years ago

timothyolt commented 5 years ago

While dependencies may be added from the Kotlin Gradle DSL, a straightforward way to add dependencies with the Groovy DSL does not appear to exist.

https://github.com/kenzierocks/ts2kt-unofficial-gradle-plugin/blob/7f8e62fd73039b4510c5d5b3bafbaf7ece1c4a85/plugin/src/main/kotlin/net/octyl/ts2kt/gradle/repository/dependency/ClientDependencyHandlerScope.kt#L34

octylFractal commented 5 years ago

I think I wrote this before I realized NamedDomainObjectContainer existed for public use as well, so the extension should be rewritten to use it. Then I don't think either extra Groovy or Kotlin DSL support is needed.

timothyolt commented 5 years ago

Nice. I had no idea it existed for public use either! This is the first plugin I have touched, just had to make it work on for my use case.

timothyolt commented 5 years ago

I have what I did to make it work in timothyolt/groovy-compatibility but I admit it may be better done with NamedDomainObjectController, so I will refrain from doing a pull request on this one