search

oculus-samples / Unity-Phanto

Phanto is a showcase of the Meta Quest Mixed Reality APIs. This project demonstrate how to use Meshes. The Oculus SDK and other supporting material is subject to the Oculus proprietary license.
Other
205 stars 50 forks source link

Update meta packages to v60 #2

Closed StephenHodgson closed 8 months ago

StephenHodgson commented 8 months ago
facebook-github-bot commented 8 months ago

Hi @StephenHodgson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 8 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

codeworks-studio commented 8 months ago

Have the update to SDK 60 been commited? Currently this does not build, textmeshpro v3 to v4 in unity also needs a fix

StephenHodgson commented 8 months ago

I built and tested this just yesterday.

What exactly are you running into?

crien-xr commented 8 months ago

Thanks for your pull request. We just pushed a commit that updates Phanto to v60 core SDK and adds support for Depth API and Haptics SDK.

crien-xr commented 8 months ago

Have the update to SDK 60 been commited? Currently this does not build, textmeshpro v3 to v4 in unity also needs a fix

It looks like there's a problem building Phanto with Unity 2023.2.3 (not just this PR). I'll see if there's a solution, but you might want to open an issue so we can track this outside of this thread. Thanks.

StephenHodgson commented 8 months ago

Please pull these changes and test, I opened the PR in good faith as a contributor.

This PR will build and run as expected.

If there's any change requests or something else that would prevent me from contributing, please let me know.