search

oculus42 / short-uuid

Translate standard UUIDs into shorter formats and back.
MIT License
450 stars 13 forks source link

Update uuid to v9.0.1 (fixes module resolution issues with Jest+jsdom) #70

Closed haraldreingruber-dedalus closed 4 months ago

haraldreingruber-dedalus commented 8 months ago

Hi,

I've updated uuid to v9 in my fork, because I ran into issues when resolving uuid in the jest-environment-jsdom.

This has been improved in v9 (https://github.com/uuidjs/uuid/blob/ca1d39d58a6308d5311bcb356a931aa818ec0ded/CHANGELOG.md#bug-fixes), so I thought it might be a good idea to move this dependency forward?

Also, note that support for Node v10 has been dropped: https://github.com/uuidjs/uuid/blob/ca1d39d58a6308d5311bcb356a931aa818ec0ded/CHANGELOG.md#-breaking-changes

What do you think about upgrading?

Thanks, Harald

chris--jones commented 6 months ago

Is there a reason to not use the built-in uuid (other than support for older Node versions)? https://nodejs.org/api/crypto.html#cryptorandomuuidoptions

oculus42 commented 4 months ago

Sorry for the long delay in response. with regard to @chris--jones I would like to implement the v9 for users of older Node releases, and then increment the major and make the latest edition use the built-in UUID generation.

oculus42 commented 4 months ago

As a note, @chris--jones the UUID package does use native crypto.randomUUID when available, but I will eliminate the uuid package dependency in 6.0.0.

oculus42 commented 4 months ago

v5.0.0 has been published with uuid v9.0.1. Thanks @haraldreingruber-dedalus