ocurity / dracon

Security scanning & static analysis tool - forked and rewritten from @thought-machine/dracon
https://ocurity.com
Apache License 2.0
61 stars 9 forks source link

Fix Python Workflow #173

Closed northdpole closed 1 month ago

northdpole commented 1 month ago

Closes

northdpole commented 1 month ago

@ptzianos seems that npm run format is broken, it consistently claims to have rewritten all md files erroneously (lint and git show nothing)

ptzianos commented 1 month ago

@ptzianos seems that npm run format is broken, it consistently claims to have rewritten all md files erroneously (lint and git show nothing)

Yes, the markdown formatter has this annoying habit of printing this message even though it hasn't changed anything in the file. This is a bug but the formatter works as expected. I checked out the branch and I ran the make fmt command and it did produce some minor fixes:

pavlos@pavlos-framework:~/projects/ocurity/dracon-oss$ git diff
diff --git a/docs/getting-started.md b/docs/getting-started.md
index 2e61320a..612d28ab 100644
--- a/docs/getting-started.md
+++ b/docs/getting-started.md
@@ -195,7 +195,6 @@ that will be picked up by the Makefile and build the container.
 You can package your components into a Helm package by running the following
 command:

-
 ```bash
 export CUSTOM_DRACON_VERSION=$(make print-DRACON_VERSION)
 export CUSTOM_HELM_COMPONENT_PACKAGE_NAME=

...

The fmt command doesn't check the stdout it only checks if some change has been applied to the files