Edit in $EDITOR - Githubissues

ocurrent / citty

CI in tty

MIT License

15 stars 7 forks source link

Edit in $EDITOR #10

Closed let-def closed 4 years ago

let-def commented 4 years ago

This PR allows to manipulate the log in the text editor set by user ($EDITOR or whatever xdg-open or open pick). To be merged after #9

craigfe commented 4 years ago

I really like this improvement.

One thought: the `Right `Activate action fails to trigger if the logs have not yet been loaded in the pane; it might be nice if the command to open the editor was buffered so that the logs will be opened as soon as they are ready. While experimenting with this branch, I often run into this issue of needing to press l more than once to get what I want :slightly_smiling_face:

let-def commented 4 years ago

I adressed both of your concerns:

VISUAL is checked before EDITOR
if the log has not been received yet, the command is scheduled
now a single log file is created (and rewritten as necessary) and deleted when the software is closed