search

ocurrent / citty

CI in tty
MIT License
15 stars 7 forks source link

Updates (lwd, ocaml-ci), reformat, support cmdliner+logs+fmt #21

Open MisterDA opened 1 year ago

MisterDA commented 1 year ago

The only problem with this PR is that warning and errors messages from Logs will be printed in stderr and disrupt the interface; but perhaps that should serve as an incentive to fix the original problem?

This also supersedes #20.

tmcgilchrist commented 1 year ago

Build failure on ocaml-ci

4 |  (libraries unix capnp-rpc-lwt current_rpc ppx_deriving_yojson.runtime)
                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Library "ppx_deriving_yojson.runtime" not found.

And the submodule should point to your fixes in https://github.com/let-def/lwd/pull/40. Other than that the changes look good.

MisterDA commented 1 year ago

Thanks for the review, I've fixed the problems.