ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
34 stars 17 forks source link

Cut down the usage of Obj.magic in the UI code #244

Closed punchagan closed 2 years ago

punchagan commented 2 years ago

The type LineGraph.DataRow.value is used ubiquitously and often with a lot of Obj.magic wrappers. This makes the UI/Graphing code very hard to understand. This PR is an attempt to make this code easier to understand by simplifying the shape of the timeseries data and restricting the use of Obj.magic only when passing the timeseries data to the Dygraph module.

art-w commented 2 years ago

This is so great! Thank you!