search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
34 stars 17 forks source link

Capture line numbers of where metrics appear in the logs #296

Closed punchagan closed 2 years ago

punchagan commented 2 years ago

This is a WIP PR, which is almost close to being finished.

punchagan commented 2 years ago

I also pushed an extra commit to correctly escape single quotes in strings

We incorrectly used a backslash to escape single quotes in literal strings. Postgres docs [1] recommend using two adjacent single quotes to escape a single quote in a literal string.

[1] - https://www.postgresql.org/docs/12/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS

punchagan commented 2 years ago

image

I've pushed a few commits to link to the log lines from the UI for each metric. A small :question: is displayed that links to the specific lines in the log. The feature would depend on https://github.com/ocurrent/ocurrent/pull/309 being merged.

PS: for some reason the commits don't seem to show up in the GitHub UI. :worried: And I don't see anything on https://www.githubstatus.com/ . I re-based one of the commits and re-pushed to GitHub and the problem is gone.

punchagan commented 2 years ago

@art-w can you take another look at this PR and merge it, if it looks good to you? This will at least start capturing the line numbers of metrics in the DB. The UI link will not be functional until ocurrent PR is merged, but we could hide the UI element, if required.

art-w commented 2 years ago

LGTM Thanks!