ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Correctly handle carriage returns when counting line numbers #345

Closed punchagan closed 2 years ago

punchagan commented 2 years ago

Previously, the line number counting code didn't increment line numbers when encoutering carriage returns. This is in-line with the line numbers displayed by Unix tools like cat -n, for instance. But browsers treat \r characters differently -- \r, \r\n and \n, all display a newline in browsers.

art-w commented 2 years ago

It looks very good, thanks!