search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Hide closed PRs #346

Closed art-w closed 2 years ago

art-w commented 2 years ago

The old closed/merged PRs are always visible in the sidebar, which makes it harder to survey all the active benchmarks. These PRs also tend get stuck in a "running" state: https://autumn.ocamllabs.io/ocaml/dune/pull/5270?worker=autumn&image=ocaml%2Fopam%3Adebian-11-ocaml-4.13

punchagan commented 2 years ago

Hmm, they should actually get pushed to Cancelled state, if it is cancelled after the cancel hooks have been setup. Also, looks like this particular PR in question was closed about the same time when this change was merged. So, it was probably not deployed?

Agree with hiding closed PRs to make it easier to navigate active benchmarks in the sidebar.

art-w commented 2 years ago

Ha yes, it would be nice to check if the cancel hooks are really executed when we restart the pipeline (I found a few PRs in the "cancelled" state, but there are a lot of old ones still marked as "running")