search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Record commit messages and display them on hover on commit IDs #356

Closed punchagan closed 2 years ago

punchagan commented 2 years ago

This commit depends on a modified version of ocurrent that fetches the commit messages from GitHub. The PR temporarily points to that commit of ocurrent. I'm not sure if we should wait to merge this PR until we submit that change, or if there's a better way to go about this.

art-w commented 2 years ago

It looks very good (including the ocurrent patch!) :100: I think we can wait a bit to see if they are willing to include it officially :)

punchagan commented 2 years ago

It looks very good (including the ocurrent patch!) 100 I think we can wait a bit to see if they are willing to include it officially :)

Thanks @art-w for the review and your help with working on this. (I still haven't figured out the best workflow to make changes in ocurrent and use them with current-bench, but discussing some of this with you helped put some things in perspective.)

punchagan commented 2 years ago

Updated this PR with a commit which pins the ocurrent version to the latest dev version. It also required adding an explicit dependency on dockerfile since ocurrent no longer depends on it.

art-w commented 2 years ago

Thanks a lot!