Closed punchagan closed 2 years ago
It looks very good (including the ocurrent patch!) :100: I think we can wait a bit to see if they are willing to include it officially :)
It looks very good (including the ocurrent patch!) 100 I think we can wait a bit to see if they are willing to include it officially :)
Thanks @art-w for the review and your help with working on this. (I still haven't figured out the best workflow to make changes in ocurrent
and use them with current-bench
, but discussing some of this with you helped put some things in perspective.)
Updated this PR with a commit which pins the ocurrent
version to the latest dev version. It also required adding an explicit dependency on dockerfile
since ocurrent
no longer depends on it.
Thanks a lot!
This commit depends on a modified version of
ocurrent
that fetches the commit messages from GitHub. The PR temporarily points to that commit ofocurrent
. I'm not sure if we should wait to merge this PR until we submit that change, or if there's a better way to go about this.