ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Failed state persists after successful rebuild #372

Closed art-w closed 2 years ago

art-w commented 2 years ago

Sometimes the benchmarks fails out of bad luck (e.g. network failures during the docker build). One can hit the "Rebuild" button on the build logs page which will fix the misstep. However, the current-bench database still remembers the initial failure with the failed=true and reason column -- and the frontend keeps displaying the commit as failing.

(It's probably not ideal that the database has both success, failed and cancelled columns, I'm not sure how to interpret them when more than one is true!)