search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Add some clarifications to readme #409

Closed gridbugs closed 1 year ago

gridbugs commented 1 year ago

Added some notes that would have helped me when getting started with current-bench.

gridbugs commented 1 year ago

Also note that I just guessed that this is how it works based on observation. Please correct me if I have it wrong!

ElectreAAS commented 1 year ago

Thanks for the PR @gridbugs!

ElectreAAS commented 1 year ago

The behaviour you describe is indeed what is happening so I'd say let's merge this PR and fix the "run benchmarks on every commit on main" bug, and we'll change the readme at that time.

@gridbugs you'll just need to rebase on main (or manually resolve the conflicts) and we're good to go

gridbugs commented 1 year ago

Rebased! Thanks!

punchagan commented 1 year ago

Thanks for taking the time to work on this!