search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

OCluster 0.2.1 packages #420

Closed MisterDA closed 1 year ago

MisterDA commented 1 year ago

Updating to OCluster 0.2.1 packages, I've noticed that Dune lower bounds were out of sync between opam files and dune-project. I'm also testing whether the upper bound to Dune 3.5 can be lifted (btw, I suggest moving to Dune 3, which enables more warnings). Lifting the constraint on prometheus-app from = 1.2 to >= 1.2 will also allow benefiting from future patch releases. There might be other updates needed, perhaps to deployment Dockerfiles (such as the opam-repository sha (in which case I suggest https://github.com/ocaml/opam-repository/commit/c59aec93bab15c48f633a83cea5344ddbfbf5556)).

ElectreAAS commented 1 year ago

With the latest fixes, this passes the main tests and the failures are completely unrelated. I'll merge as is and fix the rest separately. Thanks for the PR @MisterDA !