search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Couple of improvements to using a separate bench_repo #431

Closed punchagan closed 1 year ago

punchagan commented 1 year ago

1.Skip installing opam dependencies of the repo when using separate bench_repo

  1. Ensure cached bench_repo is used only when the bench_repo has no changes. We use the GitHub refs API to see if the repo has changed, to decide whether to use the cached bench_repo or make a new clone of it. The trick here is from this GitHub issue comment.
  2. Support specifying a specific branch of the bench_repo to use for running the benchmarks. The branch can be specified using the /tree/<branch-name> suffix in the bench_repo URL.
punchagan commented 1 year ago

I think we can ship with the FIXME regarding github assumption for the time being, and add an issue to git clone properly from other sources afterward

Yes, I agree. That was my intention too, with adding the FIXME.

punchagan commented 1 year ago

Thanks for the review and the merge, @ElectreAAS!