search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Include the base branch path in pull URLs #439

Closed punchagan closed 1 year ago

punchagan commented 1 year ago

a2bc44e2b45638bf9616705ae856855d639bcece changed the URL path to include the name of the base branch against a pull-request has been opened. This commit fixes the URLs for pulls shared in Slack notifications.

Also, re-use code from to_path in github_status_url function. Fixes #435.

ElectreAAS commented 1 year ago

LGTM! Thanks for the fix, I didn't think anyone read the slack notifications ;)

punchagan commented 1 year ago

Haha, yes, I was trying to look at the queue of work being processed by current-bench after the latest deploy which added a bunch of benchmarks to be run on the dune repo. But this PR also fixes the GitHub status URLs, for which we've already got a couple of reports. #435 and https://github.com/ocaml-multicore/eio/pull/500#issuecomment-1532731208 should both be fixed with this PR.

punchagan commented 1 year ago

Thanks for the review and the merge, @ElectreAAS ! :)