ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Investigate current-bench removing statuses of other checks on `master` #440

Open punchagan opened 1 year ago

punchagan commented 1 year ago

Reported here by @kit-ty-kate

punchagan commented 1 year ago

Looks like this is the offending commit.

punchagan commented 1 year ago

The logs for the set-status job look like this:

2023-04-25 17:53.03: New job: Set ocaml/opam refs/heads/master
                     e66648f0/ocaml-benchmarks to
                     {"state":"pending","target_url":"https://autumn.ocamllabs.io/ocaml/opam"}
2023-04-25 17:53.03: Waiting for resource in pool github
2023-04-25 17:53.07: Got resource from pool github
2023-04-25 17:53.07: POST https://api.github.com/repos/ocaml/opam/statuses/e66648f07b950e5ba144a477432f437bfd8059ec:
                       {
                         "context": "ocaml-benchmarks",
                         "state": "pending",
                         "target_url": "https://autumn.ocamllabs.io/ocaml/opam"
                       }
2023-04-25 17:53.08: Job succeeded

I've looked at the code, and tried to look at the API docs and it doesn't seem like something like this would "delete" other statuses.

kit-ty-kate commented 1 year ago

The same thing happened for already opened PRs on ocaml/opam

punchagan commented 1 year ago

Okay, thanks for the additional information.