search

ocurrent / current-bench

Experimental benchmarking infrastructure using OCurrent pipelines
Apache License 2.0
33 stars 17 forks source link

Fix the github-app.sh script that allows locally testing with a GitHub app #456

Closed punchagan closed 1 year ago

punchagan commented 1 year ago

This PR fixes a couple of things that were broken which broke the local dev workflow with a test GitHub app.

1) ngrok added more domain names to their list of domains, but we looked only for ngrok.io 2) dune exec cannot be run in a project, after a dune exec --watch has already started.

The commit messages have more explanations on the bugs and the fixes.

punchagan commented 1 year ago

Thanks for the review, @art-w !

@ElectreAAS let me know if you want me to merge this PR myself, or if you'd like to review and merge it.

ElectreAAS commented 1 year ago

Thanks @punchagan for all this work :)

punchagan commented 1 year ago

Thanks for taking the time to review, @ElectreAAS !