ocurrent / obuilder

Experimental "docker build" alternative using btrfs/zfs snapshots
Apache License 2.0
60 stars 17 forks source link

Fix use of sudo logic in Os.copy #148

Closed dustanddreams closed 1 year ago

dustanddreams commented 1 year ago

Os.copy is not used by anything, but just in case:

MisterDA commented 1 year ago

It was needed at some point of the development of the Docker backend, and was probably going to be used for macOS (until it wasn't), which is why I included it earlier. The idea with superuser was to request the copy to be run as super user: it's not usually needed, but sometimes you want to copy files as root to a privileged destination. Note that OBuilder can run as a regular user, and uses sudo accordingly. I'm tempted to remove this function altogether since it's not used anymore, even in the Docker backed.

dustanddreams commented 1 year ago

The idea with superuser was to request the copy to be run as super user: it's not usually needed, but sometimes you want to copy files as root to a privileged destination.

Ok. Then I'll withdrawn this PR.