ocurrent / ocaml-ci

A CI for OCaml projects
https://ocaml.ci.dev
112 stars 74 forks source link

Opam pin depends refactors #831

Closed MisterDA closed 2 months ago

MisterDA commented 1 year ago

Follow-up to #791 and fix #826. ocaml-ci itself uses git and tar pin-depends, if it builds correctly the changes are (likely) correct too!

benmandrew commented 1 year ago

I ran on my own fork of OCaml-CI (benmandrew/ocaml-ci) and had some failures:

On the master branch I had:

2023-06-26 16:26.06: ocaml-ci-web.dev: found pin-depends: tailwindcss.~dev -> https://github.com/tmattio/opam-tailwindcss/archive/f0d65be5f94322f48497b33bc05c057882d57977.tar.gz
2023-06-26 16:26.06: ocaml-ci-web.dev: found pin-depends: tailwindcss.~dev -> https://github.com/tmattio/opam-tailwindcss/archive/f0d65be5f94322f48497b33bc05c057882d57977.tar.gz
2023-06-26 16:26.06: Job failed: Tar.Header.Checksum_mismatch

On the keep-capnp-secrets branch the analysis succeeded (along with the builds) but there appears to have been some non-fatal errors:

2023-06-26 16:26.03: ocaml-ci-web.dev: found pin-depends: tailwindcss.dev -> git+https://github.com/tmattio/opam-tailwindcss#f0d65be5f94322f48497b33bc05c057882d57977
2023-06-26 16:26.03: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:tailwindcss.opam"
2023-06-26 16:26.03: ocaml-ci-web.dev: found pin-depends: tailwindcss.dev -> git+https://github.com/tmattio/opam-tailwindcss#f0d65be5f94322f48497b33bc05c057882d57977
2023-06-26 16:26.03: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:tailwindcss.opam"
fatal: cannot change to '/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c': No such file or directory
2023-06-26 16:26.03: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:opam/tailwindcss.opam"
fatal: cannot change to '/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c': No such file or directory
fatal: cannot change to '/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c': No such file or directory
2023-06-26 16:26.03: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:opam/tailwindcss.opam"
2023-06-26 16:26.03: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:opam"
fatal: cannot change to '/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c': No such file or directory
2023-06-26 16:26.03: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:opam"
fatal: cannot change to '/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c': No such file or directory
2023-06-26 16:26.03: Exec: "git" "clone" "-q" "https://github.com/tmattio/opam-tailwindcss" 
                           "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c"
fatal: cannot change to '/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c': No such file or directory
2023-06-26 16:26.57: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "show" "f0d65be5f94322f48497b33bc05c057882d57977:tailwindcss.opam"
2023-06-26 16:26.57: Exec: "git" "-C" "/Users/benmandrew/projects/t/ocaml-ci/var/pin-depends/opam-tailwindcss-15d4d53849bf40e63de281bc9ea2f28c" 
                           "fetch"
MisterDA commented 1 year ago

Well then I'll write tests and inspect what's going on. Thank you very much for trying this!

shonfeder commented 2 months ago

Please feel free to reopen this is you resume work on it!