search

ocurrent / ocaml-ci

A CI for OCaml projects
https://ocaml.ci.dev
112 stars 74 forks source link

`lint-doc` uses lower-bounds for installing dependencies #872

Closed edwintorok closed 11 months ago

edwintorok commented 1 year ago

Context

Although using lower-bounds for installing packages is a good way to find bugs there are other CI steps that do that already (and a lower-bound failure may be due to a dependency of a package and not a bug in the package being tested). To maximize the usefulness of the lint-doc step it should focus on linting the documentation and the best chance of doing that successfully is by installing the latest version of all dependencies as opam normally would.

Step(s) to reproduce

https://ocaml.ci.dev/github/edwintorok/lintcstubs/commit/8db4abc2ae1f8c579940a6a98940a41419a7aca0/variant/%28lint-doc%29

Expected behaviour

lint-doc starts checking documentation and doesn't fail on installing dependencies.

Technical details

There are other CI steps that show that the package itself does build when not using lower bounds (and the lower bound bug is being fixed in an opam PR currently): https://ocaml.ci.dev/github/edwintorok/lintcstubs/commit/8db4abc2ae1f8c579940a6a98940a41419a7aca0

benmandrew commented 11 months ago

Thanks for reporting, I missed this issue but ran into the same problem myself independently! Fixed by #878.