search

ocurrent / ocaml-ci

A CI for OCaml projects
https://ocaml.ci.dev
MIT License
112 stars 74 forks source link

Fix x32_86bit job caused by capnproto #894

Closed moyodiallo closed 11 months ago

moyodiallo commented 1 year ago

This is a temporary fix, it may take time to have new release of Debian following bookworm, that fixes capnproto.

Issue related to https://github.com/mirage/capnp-rpc/issues/273. And a PR is addressed to capnproto https://github.com/capnproto/capnproto/pull/1824

reynir commented 1 year ago

Hi! I don't understand how since this PR is unmerged, but it seems to affect CI for us. Our test on debian x86_32 fails due to test failures in capnproto. We don't (transitively) depend on capnproto so it isn't something that should be built. Furthermore, the Dockerfile commands match exactly with this PR.

https://ocaml.ci.dev/github/robur-coop/miragevpn/commit/27f5ea3ae48bd99b8bcf1099d81ab61075020b36/variant/debian-12-5.1_x86_32_opam-2.1

moyodiallo commented 1 year ago

We don't (transitively) depend on capnproto so it isn't something that should be built. Furthermore, the Dockerfile commands match exactly with this PR.

You're right, good point. I'll fix it by testing against the dependencies. Thks.

moyodiallo commented 1 year ago

Hi! I don't understand how since this PR is unmerged, but it seems to affect CI for us.

I deployed it by merging it to the live-engine branch in order to test it before merging it on master branch.

reynir commented 1 year ago

Hi! I don't understand how since this PR is unmerged, but it seems to affect CI for us.

I deployed it by merging it to the live-engine branch in order to test it before merging it on master branch.

Ah good, I am relieved to hear this. For a few minutes I was worried any latest commit or PR was used to build the docker image(!)

moyodiallo commented 1 year ago

Thanks for that report, I deployed the fix and It's working. https://ocaml.ci.dev/github/robur-coop/miragevpn/commit/c2dc140344a1d971de7f8e1b042822b2109c39ed.

benmandrew commented 1 year ago

@moyodiallo can this be merged?

moyodiallo commented 1 year ago

@moyodiallo can this be merged?

Not yet, this PR needs some further discussion with @tmcgilchrist.

moyodiallo commented 11 months ago

After a discussion with @tmcgilchrist, it is preferable to not add patched system libraries in the CI. So this PR is replaced by https://github.com/ocurrent/ocaml-ci/pull/902.

moyodiallo commented 11 months ago

This won't be merged.

reynir commented 10 months ago

Hi this seems to be back and making unrelated builds fail :(

moyodiallo commented 10 months ago

Hi this seems to be back and making unrelated builds fail :(

Would you like give a link ?

reynir commented 10 months ago

https://ocaml.ci.dev/github/robur-coop/miragevpn/commit/3d5d67c28361710b88394fe7509180175e6253c9/variant/debian-12-5.1_x86_32_opam-2.1

moyodiallo commented 10 months ago

Sorry the there is wrong deployment, I will fixed that. The master branch is free from this error.

moyodiallo commented 10 months ago

After verification and new deployment without this fix, the error wasn't coming from this. This is related to https://github.com/ocurrent/ocaml-ci/issues/914.

reynir commented 10 months ago

Well it is still building capnproto in the build I posted above even if it is unrelated to the package being built.