ocurrent / ocaml-ci

A CI for OCaml projects
https://ocaml.ci.dev
MIT License
112 stars 75 forks source link

Promote FreeBSD and MacOS to non-exprimental #944

Closed shonfeder closed 5 months ago

shonfeder commented 5 months ago

MacOS and FreeBSD are currently tagged as "experimental platforms":

https://github.com/ocurrent/ocaml-ci/blob/bd28414e04b4d743f290a0f6e3ff27ad8797cef4/lib/build_info.ml#L10-L37

Which means that even if those CI checks have failed or are not finished, the overall status of a job can show as green. This recently led to a problem, reported by @polytypic, where the development CI was showing all green, masking non-completing FreeBSD jobs that were actually signs of a problem.

MacOS was added in cffaa14c320cc2803722f36bc1bcb9d208b86264, in Oct of 2022 and marked as experimental in Dec with b8f1733 .

FreeBSD was added more recently, just under a year ago, in c2df7fea51f0f166c06c19d2ff0f4fcb73a7ed0b.

However, we think it may be time to promote these variants to non-experimental targets.

Thoughts?

polytypic commented 5 months ago

Yes. If some platform on OCaml-CI is too unstable for some reason for some project I'm developing, I might, for example, exclude that platform (at the package level) or skip tests via other means on OCaml-CI for that platform.

mtelvers commented 5 months ago

I would like to see both FreeBSD and macOS promoted out of experimental.

tmcgilchrist commented 5 months ago

I agree they are both stable and have sufficient capacity to be promoted out of experimental.

On Tue, 11 Jun 2024 at 12:59 AM, Mark Elvers @.***> wrote:

I would like to see both FreeBSD and macOS promoted out of experimental.

— Reply to this email directly, view it on GitHub https://github.com/ocurrent/ocaml-ci/issues/944#issuecomment-2158596948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJXOIEGWPUUAGKWQ66IY3ZGW5NBAVCNFSM6AAAAABIXQP62GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYGU4TMOJUHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>