ocurrent / ocaml-ci

A CI for OCaml projects
https://ocaml.ci.dev
MIT License
111 stars 74 forks source link

Fix order of steps in lint-fmt job #959

Closed mtelvers closed 3 months ago

mtelvers commented 3 months ago

Reworking fixing an error Shon introduced in https://github.com/ocurrent/ocaml-ci/pull/937

This commit is on live-engine but does not appear on master

shonfeder commented 3 months ago

Huh... looking at the history here, I am quite confused about why I didn't merge this into master in the first place via my PR, why it was deployed an not merged etc... :/

I clearly messed up there, so thanks for the fix. IMO, this points to the need for a cleaner CD story here (and a staging env so we don't need to test on prod). But those needs are tracked already. Thank you for the fix and sorry for the trouble!