search

ocurrent / ocaml-ci

A CI for OCaml projects
https://ocaml.ci.dev
MIT License
112 stars 75 forks source link

Investigate marking `opam-dune-lint` check as non-experimental #969

Closed punchagan closed 2 months ago

punchagan commented 2 months ago

opam-dune-lint does some useful checks, for instance, ensuring projects have LICENSE files and license entries. It looks like a bunch of projects fail the lower bounds check, though.

Investigate what it would take to mark the check as non-experimental.

punchagan commented 2 months ago

The license check in opam-dune-lint is a warning and doesn't fail the check. :shrug:

shonfeder commented 2 months ago

Since this wouldn't even solve the problem we had in mind, maybe we can just close this investigation as solved?

punchagan commented 2 months ago

Yes, I think so. opam lint doesn't catch the license missing issue.

Also, the additional check that opam-dune-lint does was to make sure all "ocamlfind libraries listed as dune dependencies have corresponding opam dependencies listed in the opam files". I think making this check mandatory would be quite a big change and need more discussion, etc.