search

ocurrent / opam-repo-ci

An OCurrent pipeline for testing submissions to opam-repository
19 stars 21 forks source link

Refactor build specs #290

Closed benmandrew closed 1 month ago

benmandrew commented 2 months ago

This PR separates the Build and List_revdeps jobs into two modules, sharing code by a functor for both local_build.ml and cluster_build.ml.

Other little bits of refactoring are done.

mtelvers commented 2 months ago

This PR causes all jobs to succeed without actually doing anything. See https://github.com/ocaml/infrastructure/issues/110.

shonfeder commented 1 month ago

IIUC, this change es not currently on the critical pass for any of our objectives, and given the conflicts and the problem when deploying, it will need to be re-worked if we want to move forward with it. As such, I propose we open an issue to track this proposed refactor, perhaps push the change to branch on this repo, and close this PR. What do you think, @benmandrew and @mtelvers ?

benmandrew commented 1 month ago

Closing with the change pushed to the refactor-build branch (https://github.com/ocurrent/opam-repo-ci/tree/refactor-build).