search

ocurrent / opam-repo-ci

An OCurrent pipeline for testing submissions to opam-repository
19 stars 21 forks source link

Don't check name collisions for existing packages #292

Closed benmandrew closed 1 month ago

benmandrew commented 2 months ago

...and increase divisor from 6 to 16 to reduce false positives.

Extension of https://github.com/ocurrent/opam-repo-ci/pull/284.

benmandrew commented 2 months ago

Fixes issue mentioned in https://github.com/ocaml/opam-repository/pull/25678#issuecomment-2060638622.

hannesm commented 3 weeks ago

Thanks for your work. As far as I observe, this does 95% of what the title advertises: if there's a single version released to opam repository, and this one is modified, the check kicks in.

So, if we have foo.0.1.0 released, and someone modifies it (due to upper bounds or whatever), this check for name collisions is run when it should not.

I'm not sure how an appropriate fix would be, since you'll need the old git state vs the new git state, and peek whether in the old state that package was already present.

shonfeder commented 3 weeks ago

The rest of that logic should be taken care of in https://github.com/ocurrent/opam-repo-ci/pull/316, if I'm not mistaken.

We are just waiting on final approval for the prefix logic before merging and deploying that.