ocurrent / opam-repo-ci

An OCurrent pipeline for testing submissions to opam-repository
19 stars 21 forks source link

Remove redundant --installable flag alongside --coinstallable-with #303

Closed punchagan closed 1 month ago

punchagan commented 1 month ago

The --installable flag runs a filter using the installable_subset function, which is just a call to the coinstallable_subset function with an empty set as the coinstallable set of packages. The other argument of --coinstallable-with already runs the same filter with the specified package as the set with which need to be coinstallable.

benmandrew commented 1 month ago

Looks good to me, could you update the expect tests?

punchagan commented 1 month ago

Looks good to me, could you update the expect tests?

Updated! Apologies for missing them on the original commit.

(Also, pushed an unrelated minor typo fix commit, separately)