search

ocurrent / solver-service

An OCluster service for solving opam dependencies
Apache License 2.0
12 stars 7 forks source link

DO NOT MERGE: Remove vendored dependencies #32

Closed tmcgilchrist closed 1 year ago

tmcgilchrist commented 1 year ago

Working around this bug in Dune.

Originally raised as https://github.com/ocaml/dune/pull/6577

talex5 commented 1 year ago

Why not merge this? CI is (mostly) passing, so it seems these aren't needed at all.

talex5 commented 1 year ago

I've made an updated version of this at #68.

tmcgilchrist commented 1 year ago

@talex5 if we don't need the submodule vendoring (in ocaml-ci) we could get rid of this branch. Ideally when we need to consume this from ocaml-ci we only want the capnp generated API package.

talex5 commented 1 year ago

There aren't any submodules at the moment (they were removed in #68) - this PR is now just removing the left-over .gitmodules file.

(note: there's also the (vendored_dirs ocluster ocurrent ocaml-dockerfile) line in dune, but it's not doing any harm and we might want to add them again later)