search

ocurrent / solver-service

An OCluster service for solving opam dependencies
Apache License 2.0
12 stars 7 forks source link

Enabled solving for lower-bounds of package versions #34

Closed benmandrew closed 1 year ago

benmandrew commented 1 year ago

This functionality is exposed with a new boolean flag in the Solve_request struct in api/worker.ml. This is a breaking change for existing programs instantiating the request struct directly, such as OCaml-CI.

Is this OK? (I will introduce a PR making the required change in OCaml-CI also.)

moyodiallo commented 1 year ago

Would you like to format (dune fmt).

moyodiallo commented 1 year ago

(I will introduce a PR making the required change in OCaml-CI also.)

Yes you can make it and we'll need another one for OCaml-multicore-CI.

tmcgilchrist commented 1 year ago

When you merge this, you need to update this branch/PR https://github.com/ocurrent/solver-service/pull/32 and update the git submodules in ocaml-ci / ocaml-multicore-ci. @benmandrew