search

ocurrent / solver-service

An OCluster service for solving opam dependencies
Apache License 2.0
12 stars 7 forks source link

OCaml 5+ is a multicore release #38

Open dra27 opened 1 year ago

dra27 commented 1 year ago

Partial fix (hopefully) for the problems being seen with lwt, etc.

dra27 commented 1 year ago

This is deployed on live at the moment, and has unblocked, say, Lwt. See also https://github.com/ocurrent/ocaml-version/issues/58.

dra27 commented 1 year ago

Now that OCaml 5 is multicore, it's possible that a lot of this special-case trickery used for multicore isn't necessary. However, it's important if that's implemented to be sure that we don't lose the testing matrix... e.g. for Lwt, the main libraries should continue to be tested on 4.08-5.0 with lwt_domain only being tested on 5.0.

tmcgilchrist commented 11 months ago

This explicit is_multicore code has been removed and should be handled correctly in solver-service / ocaml-ci. I've added a test in https://github.com/ocurrent/solver-service/pull/73 to be more explicit about it.

It might also be useful to have some testing in ocaml-ci to ensure certain packages have stable Analysis results. LWT project being a good example which should have a solution for many older OCaml versions.