search

ocurrent / solver-service

An OCluster service for solving opam dependencies
Apache License 2.0
12 stars 7 forks source link

Only build co-installable packages on supported compilers #40

Closed benmandrew closed 1 year ago

benmandrew commented 1 year ago

Fix for https://github.com/ocurrent/ocaml-ci/issues/470. The functionality for filtering out incompatible root packages already existed in the code, but it was prevented from working by the explicit multicore-release check.

38 is a solution for the special case of OCaml 5, but is only necessary in the presence of the multicore check. As far as I can tell the check is no longer necessary now that OCaml 5 is released and domains/effects are packages.

While it seems to work on my end I'd appreciate feedback from someone more knowledgeable.

moyodiallo commented 1 year ago

LGTM :+1: . Thanks for the PR, some work needs to be done on ocaml-multicore-ci config before the merge.

benmandrew commented 1 year ago

@moyodiallo the work has been done here: https://github.com/ocurrent/ocaml-multicore-ci/pull/41

Can this PR be merged and deployed? After that I can update ocaml-multicore-ci submodules.

moyodiallo commented 1 year ago

Yes, after an extra-review, it can be merged and deployed on the live branch.