ocurrent / solver-service

An OCluster service for solving opam dependencies
Apache License 2.0
12 stars 7 forks source link

Fix the issue of cancelling jobs #54

Closed moyodiallo closed 1 year ago

moyodiallo commented 1 year ago

A job from the scheduler was not cancelled after its switch was off. After auto-cancelling lot of jobs in OCaml-CI, the solver-service get stuck and can't start solving new request until finish the oldest.

This is part of solving https://github.com/ocurrent/solver-service/issues/53

moyodiallo commented 1 year ago

This is already tested with #52. After the review, we could revert this PR https://github.com/ocurrent/ocaml-ci/pull/768.

moyodiallo commented 1 year ago

Is there any other suggestion before the merge ?

moyodiallo commented 1 year ago

However, it can still be nice to have another review from someone else :)

Thanks for your review, it was very helpful. I don't know how else would be interested for further review.

For extend, I'm cleaning the stress tests https://github.com/ocurrent/solver-service/pull/52 to however would like to test the differences.

cc @tmcgilchrist