ocurrent / solver-service

An OCluster service for solving opam dependencies
Apache License 2.0
12 stars 7 forks source link

Move lower-bound to `Vars.t` and `Selection.t` #60

Closed benmandrew closed 1 year ago

benmandrew commented 1 year ago

Moves the ability to request a lower-bounds solve from Solve_request.t to Vars.t and Selection.t. This is a breaking change for OCaml-CI as it uses these structs directly, a PR for that will be opened shortly.

The reason for the change is that sending two solve requests that differ only in [lower_bound] causes race conditions writing to the OCurrent job log. It is much more natural to instead represent a lower-bound build with an explicitly different platform.