search

ocwebutils / sc_rules

Rules and Schemas used by sanitychecker project
https://sanitychecker.ocutils.me
MIT License
3 stars 0 forks source link

[Bug] Comet Lake Desktop (Booter/Quirks/ProtectUefiServices) #3

Closed 5T33Z0 closed 2 years ago

5T33Z0 commented 2 years ago

When testing the config of my 10th Gen Intel Core Desktop, I noticed there's an error in one of the Booter Quirks matches.

Booter/Quirks

→ This is wrong. According to the OC Install Guide, ProtectUEFIServicesmust be enabled. Reference: https://dortania.github.io/OpenCore-Install-Guide/config.plist/comet-lake.html#booter

Greetings.

sunbos commented 1 year ago
picture1 picture2
rxri commented 1 year ago

After looking at dortania guide - expected value will not change, however the shown message will be changed to reflect that it’s only required for Z390 socket

5T33Z0 commented 1 year ago

Uhh… you are wrong again. It is required for Z490, not Z390. Quote from "More In-depth Info":

Protects UEFI services from being overridden by the firmware, required for Z490.

rxri commented 1 year ago

Uhh… you are wrong again. It is required for Z490, not Z390. Quote from "More In-depth Info":

Protects UEFI services from being overridden by the firmware, required for Z490.

@sunbos is specifically mentioning laptop rules in their screenshots. I'm not sure why they posted these screenshots there since this is an issue about Desktop rules

image

However, like you mentioned, this quirk is required on Desktop with Z490 socket

5T33Z0 commented 1 year ago

Ah, ok. I mean the Topic is about Desktops.

But there's another issue with the Laptop Installation Guide which is a concern for evaluating the suggested setting: Z390 and Z490 are Desktop chipsets exclusively. Mobile chipsets for 9th and 10th gen Intel have completely differnent names:

9th Gen: https://en.wikipedia.org/wiki/List_of_Intel_chipsets#Mobile_chipsets_2 10 Gen: https://en.wikipedia.org/wiki/List_of_Intel_chipsets#Mobile_and_embedded_chipsets

Therefore, referring to Z390 in the Installation guide makes absolutely no sense in regards to Laptops.

This is not your fault of course, since you didn't write the guide. But I wouldn't quote Z390 in the context of a Laptop config.

rxri commented 1 year ago

If that's a case, then I will change the expected value to Enabled in Laptop rules

5T33Z0 commented 1 year ago

I think that's a good idea.