od-c0d3r / TodoListJs

Html-Css-Js simple app

1 stars 0 forks source link

Peer to Peer Code Review #5

Open AnselemOdims opened 2 years ago

AnselemOdims commented 2 years ago

Commendations

Good job so far on the work done.
I like that your functionalities are modularized

Suggestions

Users should not be able to edit and add an empty input
I think it will be a good user experience if the checkbox remains on screen while editing.

od-c0d3r commented 2 years ago

@AnselemOdims Nice suggestions :ok_hand:, will work on it :wrench:

AlaaAlsalem commented 2 years ago

Repetition tasks

Good job so far on work done

I noticed that the user can add the same task to do more than one time, so I suggest if you make a filter on your function so you check if the same task already exists on the local storage you just ignore it and notify the user about it

od-c0d3r commented 2 years ago

That definitely will improve the UX, thanks @AlaaAlsalem :ok_hand: