od-contrib / commander

Dual pane file manager
MIT License
16 stars 15 forks source link

Is it possible to implement KAI Features? #18

Open 8Gilles8 opened 1 year ago

8Gilles8 commented 1 year ago

Hi,

I'm really glad to see this project is still expanding. I've been using this version along with Dingux Commander KAI on my RG350M. The KAI version has some good features like zip or 7z management, a different kind of view for those type of files and for opk, rar and even Playstation 1 memcards. The footer part of the screen gives more detailed informations (permissions, date and time, size, type and with symlinks, you can see were they link to). The only problem is that you can only see those for the active panel. But it's easy to switch panel to compare two files. The left panel can also expand so that you can see longer file or folder names which can sometimes be handy.

It would be wonderful if you could add those functionnalities to your version (high resolution on RG350M, editable text, picture viewer are all great functionnalities). Merging the KAI version with yours (which seems to be the mainstream one) doesn't look too hard. I tried building your version with the buildroot from OpenDingux. At first, CMake couldn't find toolchainfile.cmake file, but it wasn't where it was supposed to. Then, I modified build.sh to point to one toolchainfile.cmake file (the one which seemed to be the most adequate to me) but CMake can't find SDL (I must admit I'm not familiar with CMake).

The KAI version came from https://github.com/SeongGino/RetroGame350-AppRepo/ I can't find any github for it and it seems it's not under development. The source code is available at :https://github.com/SeongGino/RetroGame350-AppRepo/raw/master/SourceArchives/dinguxCommander_Kai-src_20200120.zip

I hope you'll be willing to do add those features to your version.

Thanks in advance.

Gilles

glebm commented 1 year ago

Feel free to contribute features from KAI as individual PRs!

Building Commander for RG350m is as simple as:

TOOLCHAIN=/opt/gcw0-toolchain ./build.sh rg350
8Gilles8 commented 1 year ago

I tried with TOOLCHAIN option, but it didn't work. That's why I went with BUILDROOT. Turns out my gcw0 toolchain had a problem. I guess I made a mistake while unpacking it. I made a clean reinstall and now it works. I don't know when I'll have the time to merge the KAI features. Might be a while. But I'll look into it whenever possible. When I get something running, I'll need a little help submitting my changes.

Thanks.

Gilles

glebm commented 1 year ago

@8Gilles8 Note that for development/testing the easiest is to build it for your host machine:

./build-host.sh
ln -s res build/res # only need to do this once
build/commander # to launch