od-contrib / commander

Dual pane file manager
MIT License
16 stars 15 forks source link

Default font size is too large, global dpi is ignored #20

Closed dfilskov closed 5 months ago

dfilskov commented 5 months ago

Thank you for your work on this great tool for Batocera. It has made file handling and editing on Steam Deck so much easier :)

Please consider making the default scaling smaller and comply with the global.dpi setting in batocera.conf

It will make it possible to see longer filenames than this:

IMG_20240512_192514~2

I've tried changing batocera.conf

global.dpi=72

... but nothing changes.

glebm commented 5 months ago

The settings are named disp_ppu_y and disp_ppu_x.

https://github.com/od-contrib/commander/blob/079a84c8a8cc25e1899cb11bcfce8e9e2ed9fca9/config.cpp#L192-L198

glebm commented 5 months ago

You may also need to set disp_autoscale_dpi to 0.

dfilskov commented 5 months ago

Thank you!! - but where do I insert these settings? - the users can't easily find out where.

glebm commented 5 months ago

Default font size is informed by the DPI returned by SDL, even if it's wrong that's outside of this app's control.

global dpi is ignored

The global dpi setting is Batocera-specific. This needs to be fixed on the Batocera side.

dfilskov commented 5 months ago

Are you sure this OD Commander uses the DPI from the SDL?

Perhaps OD Commander always uses its own inappropriate default values unless the settings file exists? (by 'inappropriate' I mean they seem to expect the user to be using an old retro CRT with only 320x240 resolution)

The font size or scaling in OD commander and in Batocera's desktop file manager's terminal look exactly the same. ... but when I change 'global.dpi' in Batocera and reboot only the font size in the terminal changes - not OD commander. Terminal reacts to the change - OD Commander doesn't.

That leads me to think that OD Commander ignores the DPI informed by the SDL.

glebm commented 5 months ago

Batocera package actually disables DPI auto-scaling by default here: https://github.com/batocera-linux/batocera.linux/blob/c7b279b97443b7eea49c6a329d19c486b4e0124a/package/batocera/utils/od-commander/od-commander.mk#L17

I don't remember why that is

dfilskov commented 5 months ago

So turning it on in commander.cfg might make OD Commander respond to the global.dpi setting?

glebm commented 5 months ago

I don't know how global.dpi works in Batocera but it's worth trying!